rust-bitcoin / rust-bitcoin / 16777505321

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4778: p2p: Allow building a "useless" address

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/90df2a1ba8847b99f2ea93b11b27c7eb1e143fed">90df2a1ba p2p: Allow building a "useless" address (rustaceanrob)

Pull request description:

  The version message in the p2p protocol includes two `p2p::Address` fields, one of these fields is completely ignored in practice. Additionally, one might want to send an unreachable address if they do not want to be discovered as a peer, i.e. they are not listening for connections.
  
  I opted out of using `Default` as this is a specific use case, and there is no reasonable default for an IP address.
  
  Reference to the line in Bitcoin Core that drops the `Address`: https://github.com/bitcoin/bitcoin/blob/v29.1rc1/src/net_processing.cpp#L3435


ACKs for top commit:
  tcharding:
    ACK 90df2a1ba8847b99f2ea93b11b27c7eb1e143fed
  apoelstra:
    ACK 90df2a1ba8847b99f2ea93b11b27c7eb1e143fed; successfully ran local tests


Tree-SHA512: 9624b3fa8aef871edbfc6f5d73e2c042b7e

Coverage Stats

0 of 3 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

21552 of 25819 relevant lines covered (83.47%)

15103.79 hits per line