rust-bitcoin / rust-bitcoin / 16764599533

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4736: p2p: Add a `UserAgent` type

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/10c61ddc1f1d7e1973fbf7a9092b4cd0a2613b6b">10c61ddc1<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/cfc381462f6b6073bad6671ccc9525eb446b334f"> p2p: Use formatted user agent (rustaceanrob)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b63357dc3cff82c77c40728b9657861e955c40df">b63357dc3</a> p2p: Add a `UserAgent` type (rustaceanrob)

Pull request description:

  There is a BIP that defines what a typical user agent should look like in a `version` message sent by a bitcoin node. All of the formatting suggestions are just recommendations, but users that would like to follow the recommendations should be able to do so easily. Instead of wasting their time reading a string formatting BIP, I attempt to make it as easy as possible here to create a user agent correctly. In practice people put stupid shit in here all the time, so there is no validation when reading these off the wire.
  
  Originally inspired by some work of nyonson, so tagging him here for a review.
  
  Hoping to not waste too much reviewer bandwidth here, so all of the test cases are pretty much unaltered. This is a convenience type for users that want to play by the rules.
  
  ref: https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki


ACKs for top commit:
  tcharding:
    ACK 10c61ddc1f1d7e1973fbf7a9092b4cd0a2613b6b
  apoelstra:
    ACK 10c61ddc1f1d7e1973fbf7a9092b4cd0a2613b6b; successfully ran local tests


Tree-SHA512: 8756d260841bae278fd6ad4a9c1156b8725

Coverage Stats

113 of 123 new or added lines in 2 files covered. (91.87%)

6 existing lines in 1 file now uncovered.

21547 of 25816 relevant lines covered (83.46%)

15159.36 hits per line