bitcoindevkit / bdk_wallet / 16763268196

85%

push

github

Merge bitcoindevkit/bdk_wallet#288: Fix `KeychainTxOutIndex` recovery logic when spk-cache is enabled

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/e2814e813feb8239d091c2704eb28a4f31664b4d">e2814e813 fix: `KeychainTxOutIndex` recovery logic when spk-cache is enabled (志宇)

Pull request description:

  ### Description

  We should ensure we populate the cache (from the changeset) before doing any other operation on `KeychainTxOutIndex` (i.e. inserting descriptors).

  Otherwise we will end up re-deriving spks which have already been cached.

  The test is also corrected to check that we don't duplicate deriving spks. A helper function `check_cache_cs` is added to make the tests more thorough and easier to read.

  ### Changelog notice

  ```md
  Fixed:
  * Recovering from spk-cache now works properly.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `just p` before pushing

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing

  > ~* [ ] This pull request breaks the existing API~
  > ~* [ ] I'm linking the issue being fixed by this PR~

ACKs for top commit:
  ValuedMammal:
    ACK e2814e813feb8239d091c2704eb28a4f31664b4d
  oleonardolima:
    cACK e2814e813feb8239d091c2704eb28a4f31664b4d

Tree-SHA512: fdfb2880e8db46b2363f5eb615520a35f0d

51 of 53 new or added lines in 1 file covered. (96.23%)

6669 of 7854 relevant lines covered (84.91%)

3481.63 hits per line