rust-bitcoin / rust-bitcoin / 16735532890
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 132
Run time 140min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.423% (-0.01%) from 83.433%
16735532890

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4725: Add a `ProtocolVersion` type with named values

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/4c7fe55258ad5e2f0dcba993cb1a5ae33658a735">4c7fe5525<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/acbc8d24a771675d4db83c029e647edbd73d701f"> p2p: Add a `ProtocolVersion` with named values (rustaceanrob)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7be9dc8d65d68de759b57b73b871112de9556c74">7be9dc8d6</a> p2p: Stop assuming the protocol version (rustaceanrob)

Pull request description:

  Protocol versions should be comparable by name when considering if we would like to maintain a connection or not. For instance it is nice to be able to say "reject all connections below this feature". It is also nice to know you aren't sending some nonsense version (e.g. 70071) because of a typo.
  
  The naming comes from similar constants defined in Bitcoin Core [here](https://github.com/bitcoin/bitcoin/blob/master/src/node/protocol_version.h).


ACKs for top commit:
  apoelstra:
    ACK 4c7fe55258ad5e2f0dcba993cb1a5ae33658a735; successfully ran local tests
  tcharding:
    ACK 4c7fe55258ad5e2f0dcba993cb1a5ae33658a735


Tree-SHA512: c8d94f1abb162e20f58075b5a659715db56

25 of 30 new or added lines in 4 files covered. (83.33%)

50 existing lines in 4 files now uncovered.

21438 of 25698 relevant lines covered (83.42%)

15144.16 hits per line

Uncovered Changes

Lines Coverage ∆ File
3
78.54
 -0.22% p2p/src/lib.rs
2
65.88
 -0.78% p2p/src/message_network.rs

Coverage Regressions

Lines Coverage ∆ File
40
78.54
 -0.22% p2p/src/lib.rs
4
63.79
 -3.39% p2p/src/message_blockdata.rs
3
65.88
 -0.78% p2p/src/message_network.rs
3
92.25
 0.02% p2p/src/message.rs
Jobs
ID Job ID Ran Files Coverage
1 16735532890.1 132
83.42
 GitHub Action Run
Source Files on build 16735532890