tari-project / tari / 16731863361

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix: memo naming from payment_id (#7385)

Description
---
- Fixed memo naming where it still referenced payment_id.
- Added a unit test to verify that a wallet payment_id address can
provide its payment_id.
- Added debug logs to gRPC method `get_payment_id_address`.

Motivation and Context
---
These changes were a result of investigating issue #7363.

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved debug logging for payment ID and address handling in the
console wallet, aiding in troubleshooting.

* **Tests**
* Added new tests to verify correct retrieval and handling of memo
fields (payment ID) in addresses.
* Enhanced test assertions for memo field extraction and address
validation.

* **Style**
* Updated parameter names and documentation to consistently use "memo"
instead of "payment ID" for improved clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

78 of 85 new or added lines in 3 files covered. (91.76%)

5 existing lines in 4 files now uncovered.

75560 of 139401 relevant lines covered (54.2%)

195388.17 hits per line