payjoin / rust-payjoin / 16728312520

83%

push

github

e2e test concurrency fixes (#913)

This PR addresses two race conditions in the e2e tests:

## Free Port Assignment

Each test tried to bind a free port, and then remembered the number
passing it in to the `--port` option of payjoin-cli. There is a brief
window where the port is unbound, allowing the same number to be given
to both tests concurrently.

Instead the payjoin-cli can be given `--port 0`, binding a free port on
its own, and will now use this port when generating a payjoin URI.

## Self Signed Certificate Isolation

The self signed certificate was written to e.g. `/tmp/localhost.der`, so
concurrent `cargo test` runs as well as concurrent tests within a test
run overwrote each others certificate.

This issue was mostly hidden by the redis test container delaying
startup for the v2 test, typically long enough for the v1 test's server
and clients to be be initialized consistently.

84 of 110 new or added lines in 5 files covered. (76.36%)

8021 of 9331 relevant lines covered (85.96%)

502.5 hits per line