trento-project / web / 7747692b0379800f3579dd14253c39e250d99967

88%

push

github

SMLM settings save/change correlation (#3640)

* Removes expiration...

...with implicit ttl

* Refactors correlation context

With this commit we now have scoped correlations for keys that are per-test process and (the default) unscoped correlations module for global keys that is intended for prod/application code usage.

* Implements correlation for software updates...

... discovery context using the previously used maybe_correlated_dispatch mechanism that correlates depending on whether there is a value available in the cache.

* See description

- Mild refactor to centralize propagation of correlation id to a single function.
- In case the correlation key is nil, we don't do any further correlation operations and return early. This is implausible in prod but necessaary for the sake of completeness, for instance in tests code that need to test scenarios both with and without correlation.

* Introduces an additional test dep

ProcessTree helps look for keys in ancestors of a given process. This is useful for instance for scenarios where there is an async call/spawn to a child process from a parent process and one wishes to check the both the parent and child processes for a key in their process dictionaries. Relevant for tests involving SMLM settings.

* Minor addition

... to add test grouping as a describe block

* Adds test setups...

... and parameterizations for with and without correlation test cases/scenarios

* Enables dep for dev env

* Implements activity logging...

.. of correlation id for save/change suse manager settings.
- Bug fix: previously changing suma settings was being logged without any metadata since the metadata pulling branch of the function was not executing. This was because of the action name not being plural (typo), i.e. changing_suma_setting instead of changing_suma_settings.

* Fix module namespace

* Fix module namespace

in tests.

* Moves scoped correlations

...module closer to tests code

* Renames module used in... (continued)

26 of 29 new or added lines in 5 files covered. (89.66%)

3694 of 4251 relevant lines covered (86.9%)

321.88 hits per line