kubevirt / hyperconverged-cluster-operator / 16710633094

76%

Build Type

push

github

Committed by web-flow

Commit Message

[Chore] several refactoring's (#3681)

* Remove duplication of getPodAntiAffinity

The getPodAntiAffinity function defined twice. This commit moved it to a
share place to cancel the duplication.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* reduce function complexity

split the ssp.go customizeCommonDictAnnotations function, into small
functions, so it would be less complex, with less nestings.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Take the golden images logic out of ssp.go

The golden images logic is meaningfully large, and takes a big part of
the ssp.go file. That creates confusions and make the file to large,
hard to read and maintained. In addition, many golden image unit tests
are duplicated, with several level of the flow.

This commit introduces the new golden-images package with all the golden images
(DataImportCron) logic, with more accurate unit test suite. Then it
removes all the golden images logic and tests from the handlers
packages, and use the new package instead.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Empty hooks.GetEmptyCr()

Several implementations of the HCOResourceHooks.GetEmptyCr(), weren't
actually empty. This commit removes any non related data from these
empty resources.

Note: left the content only in the isHooks, where it's actually in use.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Run Details

249 of 259 new or added lines in 10 files covered. (96.14%)

5 existing lines in 1 file now uncovered.

7002 of 9303 relevant lines covered (75.27%)

1.78 hits per line