benwbrum / fromthepage / 16709923910

68%

push

github

Redirect restricted collection views to landing page instead of showing errors (#4789)

* Initial plan

* Implement redirect from restricted views to collection landing page

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix test expectations for search_users and transcribe controller

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix collection authorization: make works_list public and protect edit_buttons

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix failing spec tests: correct route helper names and update works_list test expectations

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Add authorization tests for edit routes to ensure non-owners are redirected

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix authorization method to use proper redirects for HTML requests

The authorized? method now uses respond_to format blocks to ensure:
- HTML requests get proper 3xx status redirects via redirect_to
- AJAX requests get special handling via ajax_redirect_to

This fixes the failing spec tests that expected 3xx redirects for non-owner users accessing restricted collection actions.

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix authorization order: set_collection before authorized? for edit actions

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix failing feature tests by correcting test setup and authorization logic

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix document sets test setup to properly initialize collection state

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix failing feature tests by adjusting UI access and test setup

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Merge development branch and fix failing test setup

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github... (continued)

1780 of 3296 branches covered (54.0%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 2 files covered. (100.0%)

7947 of 11811 relevant lines covered (67.28%)

102.15 hits per line