rust-bitcoin / rust-bitcoin / 16689238573

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4735: Use `FeeRate` in `FeeFilter` message

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/448666c9fbb16cfad22752907f0571269d0092bb">448666c9f p2p: Use `FeeRate` in the feefilter message (rustaceanrob)

Pull request description:

  Commit one:
  
  The only purpose of the function signature using a `u32` is to ensure no overflow occurs within the body. This API doesn't mirror it's counterpart, `FeeRate::to_sat_per_kvb_*` which returns a u64. Considering `FeeRate::MAX == u64::MAX`, the respective bodies can have complimentary APIs.
  
  Furthermore, the only use for `kvb` I am aware of is BIP-133 feefilter, which is expressed as a `u64` over the wire.
  
  Commit two: 
  
  The previous `i64` is obviously not type-safe and I believe it is also wrong. BIP-133 states this value is encoded as a uint64_t. The `u64` is decoded of the wire and interpreted as sats per kvb with the help of the previous commit.


ACKs for top commit:
  apoelstra:
    ACK 448666c9fbb16cfad22752907f0571269d0092bb; successfully ran local tests
  tcharding:
    ACK 448666c9fbb16cfad22752907f0571269d0092bb


Tree-SHA512: 928bf7d2b0355499cf40d110ce49998b728

21429 of 25678 relevant lines covered (83.45%)

15272.63 hits per line