rust-bitcoin / rust-bitcoin / 16685926556

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4747: Fix check-api

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/50caaaff3b705867884e1935552533e50a932aa6">50caaaff3<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fbe6f504700f7f1dc6c6ff91336c328200994f7c"> Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2aae0dbec6c4c524873c8fdd970f7d4102769660">2aae0dbec</a> Update nightly toolchain (Tobin C. Harding)

Pull request description:

  The API checking script is failing in CI for a few reasons:
  
  - `cargo public-api` requires nightly 2025-07-17
  - The recent bot update for the nightly version failed with lint warnings. We have already merged the fixes. 
  - #4686 got through even though it introduce API changes bet we did not update the text files - this is because #4705 merged yesterday but had been sitting open for ages, I should have updated it before merge. 
  
  Fix by doing:
  
  - Patch 1: Manually update the nightly toolchain using the same version that the bot PR (#4712) would have used.
  - Patch 2: Run the check-api script


ACKs for top commit:
  apoelstra:
    ACK 50caaaff3b705867884e1935552533e50a932aa6; successfully ran local tests


Tree-SHA512: 3a0f8883edc10d0e5c4e4c2291e3820b2ac

21424 of 25672 relevant lines covered (83.45%)

15184.95 hits per line