kubevirt / hyperconverged-cluster-operator / 16679152488

76%

push

github

customize the DICT `ssp.kubevirt.io/dict.architectures` annotation (#3674)

On a multi-architecture cluster, if the user customized a common (pre-defined) DICT,
we should use the same value for the `enableMultiArchBootImageImport` DICT annotation,
as in the original DICT, because this annotation describes the image itself. However,
if the the image itself was customized, then we have no knowledge about its supported
architectures, and e must trust the customized annotation.

This commit changes the behavior of DICT customization:

If the HyperConverged CR contains a customized common DICT, and the
`enableMultiArchBootImageImport` feature gate is set to `true`, customize the DICT
`ssp.kubevirt.io/dict.architectures` annotation, as follow:

if DICT registry was not customized, use the original common DICT annotation in the
result DICT, or if it's missing from the common DICT, remove it from the result DICT.

if DICT registry was customized, use the customized DICT annotation in the result DICT,
or if it's missing from the customized DICT, remove it from the result DITC.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

30 of 30 new or added lines in 1 file covered. (100.0%)

7026 of 9272 relevant lines covered (75.78%)

1.78 hits per line