bitcoindevkit / bdk_wallet / 16660250657

85%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk_wallet#287: clippy: fix uninlined format args

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/d75126ef07d68e99cc0cdbbf6328df88b97e9955">d75126ef0<a href="https://github.com/bitcoindevkit/bdk_wallet/commit/c39ce797923e22695c6a83ed50ecf7c06386cc00"> clippy: allow `uninlined_format_args` (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/cbf0cfe59c3980fd07ee32d0acf67872dbe59bc1">cbf0cfe59</a><a href="https://github.com/bitcoindevkit/bdk_wallet/commit/c39ce797923e22695c6a83ed50ecf7c06386cc00"> chore: update rust-version to 1.88.0 (valued mammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/aa53cc13311293f4ea6ce9932bda2a1ec8e49495">aa53cc133</a> clippy: fix uninlined format args (valued mammal)

Pull request description:

  Fix #281 by taking clippy's suggestion to inline the arguments to a `format!` string where applicable.

  Also update `rust-version` to 1.88.0, closing #280.

  ### Notes to the reviewers

  I've gone ahead and fixed the clippy warnings, although some have argued that the lint is quite pedantic and not entirely helpful when it comes to style and readability. Therefore I also allowed the lint to prevent clippy from warning about it in the future d75126e. That change can be reverted if/when rust lang moves `uninlined_format_args` back to the pedantic, i.e. not default group of lints https://github.com/rust-lang/rust-clippy/pull/15287.

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [ ] ~~This pull request breaks the existing API~~

ACKs for top commit:
  notmandatory:
    ACK d75126ef07d68e99cc0cdbbf6328df88b97e9955
  oleonardolima:
    ACK d75126ef07d68e99cc0cdbbf6328df88b97e9955

Tree-SHA512: c34e701fb360fa787568f8ad834cb6eff9d

Run Details

7 of 48 new or added lines in 9 files covered. (14.58%)

1 existing line in 1 file now uncovered.

6651 of 7835 relevant lines covered (84.89%)

3484.69 hits per line