Qiskit / qiskit / 16654832041

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

improved QSD synthesis algorithm (#14721)

* add ZXZ decomposition

* merge wmatA B vmatC

* fix a misprint

* add ucrz trick

* formatting and docs

* fix failing tests

* add opt_a1 option

* update cx count upper bound

* remove UCRZGate class

* add closest unitary func to avoid M2 diagonalization errors

* update comment

* updtae documentatio and comments

* update tests

* add release notes

* fix misprints in docs

* add formula for final number of CX gates

* style updates following review

* change the default valuse of opt_a1 and opt_a2 to None

* add tests to the cases where opt_a1 or opt_a2 are None

* add release notes explaining the default behavior of opt_a1 and opt_a2

* minor

* updates following review

* Remove unused logic to build decomposition check

In an earlier commit the internal check assertion that the decomposition
was correct was removed from the code. But the logic used to build the
check matrix was kept in place. This was not used, but also the review
comment was about the expense associated with computing the check
matrix. This commit removes the unused logic.

* Remove unnecessary pylint ignores and mark unused return variables as such

* Remove unnecessary else branch and remove indent layer

* Apply suggestions from code review

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Run Details

93 of 93 new or added lines in 1 file covered. (100.0%)

23 existing lines in 4 files now uncovered.

81520 of 92868 relevant lines covered (87.78%)

548350.36 hits per line