16627053900
99%

Ran 30 Jul 2025 03:46PM UTC

Jobs 1

Files 120

Run time 1min

Badge

Embed ▾

Committed 30 Jul 2025 03:35PM UTC coverage: 98.759% (+0.001%) from 98.758%

Build # 16627053900

Build Type

push

github

Committed by

web-flow

Commit Message

[fix] Don't delete VpnClients when enforcing required templates

Bug:
The SortedManyToManyField clears all templates before adding new ones.
This operation emits an `m2m_changed` signal with the `post_clear` action,
which triggers the `Config.enforce_required_templates` receiver to add
required templates back.

Adding required templates emits another `m2m_changed` signal with the
`post_add` action, which executes `Config.manage_vpn_clients` receiver.
At this point, only required templates exist in the DB, hence we cannot
decide which VpnClient objects to delete.

Fix:
We don't delete any VpnClient objects when the `m2m_changed` signal
is sent for the `post_add` action for adding required templates.
The receiver will be called again with the `post_add` action when
all the templates are added back, including the required ones.
And then, it will delete any VpnClient objects that are not
associated with the current templates.

---------

Co-authored-by: Federico Capoano <f.capoano@openwisp.io>

Run Details

6444 of 6525 relevant lines covered (98.76%)

11.85 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python- - 16627053900.1	30 Jul 2025 03:46PM UTC	120	98.76	GitHub Action Run

openwisp / openwisp-controller / 16627053900
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16627053900

openwisp / openwisp-controller / 16627053900 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16627053900

openwisp / openwisp-controller / 16627053900
99%

README BADGES
x