rust-bitcoin / rust-bitcoin / 16626172592

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4737: p2p: Add a `V1MessageHeader`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3a89e3f72f4df5dcf9bd09ff19e95a4019be4453">3a89e3f72<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5400be4aa58ffebba0eaffded194875b9139a76e"> p2p: Add a `V1MessageHeader` (rustaceanrob)

Pull request description:

  When using `p2p` and version one messaging, the user is put into a strange position where they must figure out how many bytes to read, but cannot do so without implementing some version of this type in their crate. Add a first-class `V1MessageHeader` so users may first decoded this, then the rest of the message.
  
  An example is in Floresta here: https://github.com/vinteumorg/Floresta/blob/<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/rust-bitcoin/rust-bitcoin/commit/5e78a8179da596101508ac6ad1a454e80c1635bc">5e78a8179</a>/crates/floresta-wire/src/p2p_wire/transport.rs#L85
  
  Which is used to parse data here: https://github.com/vinteumorg/Floresta/blob/5e78a8179da596101508ac6ad1a454e80c1635bc/crates/floresta-wire/src/p2p_wire/transport.rs#L333


ACKs for top commit:
  apoelstra:
    ACK 3a89e3f72f4df5dcf9bd09ff19e95a4019be4453; successfully ran local tests; nice! Thanks for citing usecases.
  tcharding:
    ACK 3a89e3f72f4df5dcf9bd09ff19e95a4019be4453


Tree-SHA512: dfdedbabb1eb8b8d0c7ddfd59df29fcea3d

21394 of 25643 relevant lines covered (83.43%)

15228.2 hits per line