tari-project / tari / 16621916274

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat: enhance wallet connectivity monitoring (#7372)

Description
---
Closes #7360 

Enhance wallet connectivity check to proactively check it during wallet
scanning.

Previously grpc call `check_connectivity` falsely returned `Offline`
status while syncing. This was caused because it relied on `is_online`
method in `https.rs` which check if last http call was done in less than
a minute ago but initially no http calls were made and returned
incorrect value.
Now this grpc method relies on pro-actively updated value checked every
5 minutes which verifies if tip of the scanned block has changed since
the previous check.

How Has This Been Tested?
---

Replaced wallet in TU and check `get_state` and `check_connectivity`
methods calls results while scanning wallet. In both cases I received
`Online` status.

```
❯ grpcurl -plaintext -import-path tari/applications/minotari_app_grpc/proto -proto wallet.proto -d '{}' 127.0.0.1:42027 tari.rpc.Wallet/CheckConnectivity
{
  "status": "Online"
}
```

```
14:07:05 INFO  Wallet status: GetStateResponse { scanned_height: 54930, balance: Some(GetBalanceResponse { available_balance: 3107794619, pending_incoming_balance: 190000, pending_outgoing_balance: 2111889, timelocked_balance: 0 }), network: Some(NetworkStatusResponse { status: Online, avg_latency_ms: 18, num_node_connections: 11 }) }
14:07:05 INFO  Initial wallet scanning: 90.81590476977763% (54930/60485)
```

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the ch... (continued)

Run Details

0 of 3 new or added lines in 2 files covered. (0.0%)

9 existing lines in 3 files now uncovered.

75493 of 139218 relevant lines covered (54.23%)

195785.14 hits per line