kubevirt / containerized-data-importer / #5510

49%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

fix: add DataSource reference handling to authorize utils (#3831)

* fix: add DataSource reference to authorize_utils

A previous PR[1] introduced the concept of DataSource references as a way
for a DataSource to reference another DataSource.

A DV that has its sourceRef set to a DataSource reference that resides
in a different namespace would fail as authorize utils did not include
the necessary changes to the clone source handler to accomodate
DataSource references.

This commit fixes that and introduces a functional test for it.

[1] https://github.com/kubevirt/containerized-data-importer/pull/3760

Signed-off-by: Adi Aloni <aaloni@redhat.com>

* datasource-controller: prohibit cross-namespace references

Previously a DataSource could reference a DataSource in a namespace
different from its own. This is unwanted behavior and with this commit
we now error when we create such DataSources.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

---------

Signed-off-by: Adi Aloni <aaloni@redhat.com>

Run Details

2 of 5 new or added lines in 2 files covered. (40.0%)

7 existing lines in 1 file now uncovered.

17173 of 28937 relevant lines covered (59.35%)

0.66 hits per line