bitcoindevkit / bdk / 16609961651

79%

push

github

Merge bitcoindevkit/bdk#1986: ci: replace grcov by cargo-llvm-cov

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/066c4cd160f6d4c70409b299a173f31f93728fae">066c4cd16 ci: replace grcov by cargo-llvm-cov (nymius)

Pull request description:

  ### Description

  As explained in #1984 , I discovered some misreportings in the coverage information given by grcov.

  Fixes #1984

  ### Notes to the reviewers

  The discussion about the tool to use is open, but I'm adding this PR to showcase how a change from `grcov` to `cargo-llvm-cov` would look like and the improvements in reporting this change will bring. [Look the report in `coveralls`](https://coveralls.io/github/nymius/bdk?branch=ci/replace-grcov-by-cargo-llvm-cov) to get a better perspective of them.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

ACKs for top commit:
  ValuedMammal:
    ACK 066c4cd160f6d4c70409b299a173f31f93728fae
  oleonardolima:
    ACK 066c4cd160f6d4c70409b299a173f31f93728fae

Tree-SHA512: d237fcc368ca48f123cae59a464132bf38d

896 of 2002 branches covered (44.76%)

Branch coverage included in aggregate %.

4291 of 5401 relevant lines covered (79.45%)

2240.71 hits per line