rust-bitcoin / rust-bitcoin / 16605299224

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4730: p2p: Add formal `Alert` type

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5a128ba4e2cc9f7971edecfe611ea3d3c7d9a24b">5a128ba4e p2p: Add formal `Alert` type (rustaceanrob)

Pull request description:

  There is a well-known final alert message that is sent for potentially vulerable peers, but otherwise the alert system is deprecated. The only use for this message is to send the final alert, or to decide if a peer has sent a strange or unexpected alert.
  
  FWIW I tested against Regtest that `is_final_alert` evaluates to true.


ACKs for top commit:
  nyonson:
    ACK 5a128ba4e2cc9f7971edecfe611ea3d3c7d9a24b
  apoelstra:
    ACK 5a128ba4e2cc9f7971edecfe611ea3d3c7d9a24b; successfully ran local tests
  tcharding:
    ACK 5a128ba4e2cc9f7971edecfe611ea3d3c7d9a24b


Tree-SHA512: 52431bab9c69025e3a9f516c5976d515742

21388 of 25643 relevant lines covered (83.41%)

15234.83 hits per line