shinghim / rust-bitcoin / 16585542747

84%

push

github

Merge rust-bitcoin/rust-bitcoin#4713: Update `deserialize_witness` fuzz target to use the `Witness` `arbitrary` impl

<a class=hub.com/shinghim/rust-bitcoin/commit/ca344e6d0f2d832bd3fb8dd213e24d2bdd5ff4ec">ca344e6d0<a href="https://github.com/shinghim/rust-bitcoin/commit/37a7d72500c73a4e82625511a539581baf814348"> Update deserialize_witness fuzz target to use arbitrary impl (Shing Him Ng)
<a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/66f7a0a51eb74eb9bc1ac18a90948032520f38c0">66f7a0a51</a><a href="https://github.com/shinghim/rust-bitcoin/commit/37a7d72500c73a4e82625511a539581baf814348"> Rename `deserialize_amount` to `parse_amount` (Shing Him Ng)
</a><a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/180dcdc9d0c24d091029dc19cd0bb1f9d64cf31e">180dcdc9d</a> Update fuzz script to include `arbitrary` and `p2p` as a dependency (Shing Him Ng)

Pull request description:

  The result should be that the roundtrip logic is tested more often due to `arbitrary` yielding more valid Witnesses versus the previous case, which attempted to deserialize random bytes into a witness. IIUC this should also allow the fuzzer to find edge cases more easily as well


ACKs for top commit:
  apoelstra:
    ACK ca344e6d0f2d832bd3fb8dd213e24d2bdd5ff4ec; successfully ran local tests


Tree-SHA512: dec81a2cad6d6a8811e0ee5c8773d76f8f5

21386 of 25594 relevant lines covered (83.56%)

15151.01 hits per line