tari-project / tari / 16571271688
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 818
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
16571271688

push

github

web-flow 
feat: prevent sync peers sending local addresses (#7359)

Description
---
This PR prevents peers from sending local addresses during peer sync
when peer info is requested. The rationale here is that peer sync is
performed by a local node to learn about the network, and then for the
local node to attempt to contact those peers.

Motivation and Context
---
- A local node can't contact a remote peer on its internal address.
- Many peer entries in the peer db consist of peers with internal
addresses only.

How Has This Been Tested?
---
System-level testing for migrations.
Unit tests have been added to verify that only peers with their external
addresses are supplied when requested as such.

What process can a PR reviewer use to test or verify this change?
---
Code review.
System-level test.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added support for identifying and filtering peers with external
network addresses.
* Introduced database and schema changes to track whether peer addresses
are external.
* Added new test utilities for creating peers with internal or external
addresses.

* **Bug Fixes**
  * Corrected a parameter name in peer info RPC to improve consistency.

* **Documentation**
* Updated documentation to clarify address filtering and correct event
value descriptions.

* **Style**
  * Improved error mess... (continued)

75600 of 139383 relevant lines covered (54.24%)

195422.29 hits per line

Jobs
ID Job ID Ran Files Coverage
1 16571271688.1 818
54.24
 GitHub Action Run
Source Files on build 16571271688