elParaguayo / qtile / 16553662486

83%

Build Type

push

github

Committed by tych0

Commit Message

drop DefaultEventLoopPolicy

python3.14 depreciates event loop policies entirely, in favor of just
manually specifying the event loop as an argument to asyncio.run().

we were really using the event loop policy as a hack for not having a
global variable, so let's switch to a global variable instead, and use it
in the one place we need it.

we have to drop two verisons of python because they do not have the
loop_factory= argument to asyncio:

    raise AssertionError(f"Error launching qtile, traceback:\n{error}")
    AssertionError: Error launching qtile, traceback:
    Traceback (most recent call last):
      File "/home/runner/work/qtile/qtile/test/helpers.py", line 207, in run_qtile
        ).loop()
      File "/home/runner/work/qtile/qtile/libqtile/core/manager.py", line 216, in loop
        asyncio.run(self.async_loop(), loop_factory=lambda: libqtile.event_loop)
    TypeError: run() got an unexpected keyword argument 'loop_factory'

but maybe that's ok: 3.10 is outside of our last-three-versions policy, and
3.11 will be outside it in a few months when 3.14 is released.

There is another option here: since the motivation for this was really
#2620, we could "just" switch the battery to running in-loop, which would
mean that it is not run via run_in_executor() i.e. in a separate thread.
That means that get_running_loop() would return the right loop, and we
wouldn't need this hack at all.

(It also means that the battery could potentially block the UI while
reading from e.g. procfs/sysfs files, but that seems unlikely. Perhaps it
also suggests another widget type: something with an `async def poll()`,
which could run in the main loop and avoid both of these problems.)

The only other widget which uses send_notification() is pomodoro, which
doesn't read any files at all and just uses gettimeofday(), which is a VDSO
i.e. memory access, that should also not block, so if we convert the
battery widget, we should do this one as well.

Finally, we suggest us... (continued)

Run Details

6 of 8 new or added lines in 3 files covered. (75.0%)

368 existing lines in 14 files now uncovered.

16858 of 21645 relevant lines covered (77.88%)

2.76 hits per line