16545267631
92%

Ran 27 Jul 2025 12:19AM UTC

Jobs 0

Files 0

Run time –

Badge

Embed ▾

Canceled at 06 Nov 2025 08:42AM UTC via web

Build # 16545267631

Build Type

push

github

Committed by

web-flow

Commit Message

[json_syntax_generator] Make `JsonReader` private (#2446)

Addressing https://github.com/dart-lang/native/pull/2445#discussion_r2230432015

We can't make `JsonObjectSyntax` private, we use it as the type for `Map<String, Object?>` to enable overriding fields with this type with a class extending `JsonObjectSyntax` in subclasses.

```dart
AssetSyntax({required JsonObjectSyntax? encoding, required String type})
```

And then `DataAssetEncodingSyntax` is a valid type to be passed to `encoding`

```dart
class DataAssetEncodingSyntax extends _JsonObjectSyntax {
```

It would be cleaner if the runtime library would be a standalone package, and all the generated files would import that. But that requires us to publish that library on pub.dev for rolling hooks_runner into flutter_tools. So maybe the simplest solution is to keep it as is for now. (If we ever decide to make the syntax generator a fully supported project we can do it the clean way.) WDYT?

Run Details

Source Files on build 16545267631

Detailed source file information is not available for this build.

dart-lang / native / 16545267631
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 16545267631

dart-lang / native / 16545267631 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 16545267631

dart-lang / native / 16545267631
92%

README BADGES
x