bitcoindevkit / bdk / 16539295771

79%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1988: Detect new mempool txs

51ee99a39 docs(bitcoind_rpc): fixed typo in docs (Wei Chen)
73ab1eb06 chore(bitcoind_rpc): Make clippy happy (志宇)
7e894f464 feat(bitcoind_rpc)!: Use `getrawmempool` without verbose (志宇)
05464ecf8 fix(bitcoind_rpc)!: Simplify emitter (志宇)
67dfb0b14 test(bitcoind_rpc): Detect new mempool txs (志宇)

Pull request description:

  ### Description

  There is a bug in `bdk_bitcoind_rpc` where some new mempool transactions will not be emitted at all.

  This problem exists because the avoid-re-emission logic depends on rounded-to-nearest-second timestamps.

  The fix is to just emit all mempool transactions but wrap them in `Arc`s so that emission becomes cheap.

  **Background:** I tried using `bdk_bitcoind_rpc` as the chain-source to write an example to showcase the [`IntentTracker`](https://github.com/bitcoindevkit/bdk_wallet/pull/257). However, `bdk_bitcoind_rpc` failed to emit some mempool transactions.

  ### Notes to the reviewers

  The test added in c22c68f fails without these fixes.

  Some tests are removed as they are no longer relevant.

  ### Changelog notice

  ```md
  Fixed:
  - Some mempool transactions not being emitted at all. The fix is to replace the avoid-re-emission-logic with one which emits all mempool transactions.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  ~* [ ] I'm linking the issue being fixed by this PR~

ACKs for top commit:
  nymius:
    cACK 51ee99a39fbf9a6dc... (continued)

Run Details

63 of 65 new or added lines in 1 file covered. (96.92%)

1 existing line in 1 file now uncovered.

5337 of 6499 relevant lines covered (82.12%)

33155.89 hits per line