FlexMeasures / flexmeasures / 16537118334

74%

push

github

Fix/per kWh price sensors in flex context (#1628)

* feat: add test case covering flex-context sensors sharing the same unit

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: do not convert share currency unit to base units

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: no conversion needed if not converting to base units

Signed-off-by: F.N. Claessen <felix@seita.nl>

* feat: test shared SEK/MWh, too

Signed-off-by: F.N. Claessen <felix@seita.nl>

* feat: check mixing SEK/kWh with SEK/MWh, too

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: add field name to ValidationError

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: update test expectations

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Revert "refactor: no conversion needed if not converting to base units"

This reverts commit 1375efc5e.

* Revert "fix: do not convert share currency unit to base units"

This reverts commit 89b4b1a47.

* Revert "fix: update test expectations"

This reverts commit 035827800.

* feat: convert compatible units to support mixed price units like SEK/MWh with SEK/kWh

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: tests

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: derive shared currency unit from deprecated fields, for backwards compatibility

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: use static class util method

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: simplify using walrus operator

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: simplify using string concatenation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: add docstring and doctests

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>

1212 of 1776 branches covered (68.24%)

Branch coverage included in aggregate %.

8 of 9 new or added lines in 1 file covered. (88.89%)

9001 of 12173 relevant lines covered (73.94%)

5.91 hits per line