rust-bitcoin / rust-bitcoin / 16524623175

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4686: Move `locktime` and `sequence` to `units`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/029d5c6492e2c7f0080c86c0c0e4c7957c6f07aa">029d5c649<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d56834d6e745292cf4200fc09c1867e5a0e3e370"> units: Add Errors section to rustdocs (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fa0c9685f7a60b1a5a4892b87d734b506a1d219a">fa0c9685f</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d56834d6e745292cf4200fc09c1867e5a0e3e370"> Move locktime and sequence code to units (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d20e586e83ad205f140557f066a777b3925d706b">d20e586e8</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d56834d6e745292cf4200fc09c1867e5a0e3e370"> Introduce error modules to locktime (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fe62307eeaae693364598dece89dbfaab721f084">fe62307ee</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d56834d6e745292cf4200fc09c1867e5a0e3e370"> Move non-pub import into correct place (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/33ac20611eebd03e52c0b7d717b598a79d2b895a">33ac20611</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d56834d6e745292cf4200fc09c1867e5a0e3e370"> Move locktimes to module directories (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5f3d3a51c0c249e7bd79a82d9cdd86bc455f4859">5f3d3a51c Remove Transaction links from sequence docs (Tobin C. Harding)
19e54ee3a Remove links to TxIn from locktime docs (Tobin C. Harding)
48961dd5f Remove Transaction links from locktime docs (Tobin C. Harding)

Pull request description:

  In hindsight `units` is a better place for locktimes. `relative` locktime needs `Sequence`.
  
  Move all that over to `units`.
  
  - Patch 1-5 are preparatory cleanup
  - Patch 6 creates public `error` modules as discussed and implemented for `amount` in #4683
  - Patch 7 does the actual move
  - Patch 8 does docs fixes because we lint harder in `units` than `primitives`
  
  Close: #4678


ACKs for top commit:
  apoelstra:
    ACK 029d5c6492e2c7f0080c86c0c0e4c7957c6f07aa; successfully ran local tests


Tree-SHA512: b66786524579f68d2b42b9051194f61861a

Coverage Stats

295 of 435 new or added lines in 4 files covered. (67.82%)

6 existing lines in 1 file now uncovered.

21379 of 25585 relevant lines covered (83.56%)

15164.64 hits per line