payjoin / rust-payjoin / 16503850309

83%

push

github

Use FnMut closures for receiver typestate checks (#883)

In our liana wallet integration we are encountering some issues due to
how the liana devs have setup their database, namely that their db
always references a mutable self even on read calls within the db so we
need to have some mutability when accessing things like an address or
outpoint from the db. This was not possible when our closures were
limited to non-mutable.

I considered using FnOnce but we have some map methods that prevent us
from doing that as map have the possiblity of forcing the closure being
called more than once which FnOnce is limited to.

N.B. I did not make all of the closures for the typestates mutable but
perhaps we should think about their consistency for integration devs and
to limit rust-payjoin from deciding how devs should implement these type
state checks.

100 of 100 new or added lines in 6 files covered. (100.0%)

7804 of 9095 relevant lines covered (85.81%)

515.12 hits per line