mozilla-releng / balrog / #4828

90%

main: 89%

Build Type

push

circleci

Committed by web-flow

Commit Message

update to connexion 3.x (#3426)

* Replace uwsgi with uvicorn

* Update pinned dependencies

* admin: port connexion App creation to connexion 3

- use SwaggerUIOptions
- remove BalrogRequestBodyValidator, let connexion do the validation

* public: update app instanciation for connexion 3

* web: work around TypeError from connexion's ServerErrorMiddleware

See https://github.com/spec-first/connexion/issues/2059

* tests: remove check for error text in testDeleteRequiredSignoff

connexion now rejects those requests due to extra params, so the error is
different.

* tests: remove 404 test for paths that now work

* test: don't send control characters

the httpx client rejects those urls

* tests: port to new APIs

The test client for the connexion app is a starlette TestClient instead of a flask client, with a different API for responses:
- `text` attribute instead of `get_data()` method or `data` attribute
- `json()` method instead of `get_json()` method or `json` attribute
- no `mimetype` attribute, so we look up the `content-type` header instead
and requests:
- `params` argument replaces `query_string`

* tests: propagate exceptions through connexion middlewares

* admin: move CORS handling to starlette CORSMiddleware

CORS checks need to happen before routing, otherwise preflight requests
get a 405.

* admin: port statsd timers to a middleware

* public: port statsd request handler to a middleware

Run Details

3063 of 3579 branches covered (85.58%)

Branch coverage included in aggregate %.

69 of 74 new or added lines in 3 files covered. (93.24%)

3 existing lines in 1 file now uncovered.

5671 of 6194 relevant lines covered (91.56%)

0.92 hits per line