tari-project / tari / 16480452313
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 818
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 54.174% (-0.003%) from 54.177%
16480452313

push

github

web-flow 
docs: update recovery event callback in the ffi wallet recovery method (#7369)

Description
---
- ~~Fixed `RecoveryEvent` callback values to be in line with the
original FFI implementation of v4.9.1, thus no breaking change to
previous use.~~
- Updated documentation to be in line with the callback.
- Updated comments for `enum RecoveryEvent {` to be in line with recent
enum value changes

Motivation and Context
---
~~The latter release broke the FFI, and the recent documentation update
was wrong.~~
The previous FFI recent documentation update was wrong.

How Has This Been Tested?
---
Not tested - just compiled

What process can a PR reviewer use to test or verify this change?
---
Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE:


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated documentation to clarify and correct the numeric values and
order of the `RecoveryEvent` enum variants in the wallet recovery
process.
* Improved consistency in documentation comments related to wallet
recovery callbacks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

75376 of 139138 relevant lines covered (54.17%)

195802.51 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
60.64
 0.67% comms/dht/src/connectivity/mod.rs
5
70.39
 -2.43% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
5
77.99
 -0.97% comms/core/src/connection_manager/dialer.rs
6
55.33
 -0.22% comms/core/src/connectivity/manager.rs
25
0.0
 0.0% base_layer/wallet/src/base_node_service/monitor.rs
Jobs
ID Job ID Ran Files Coverage
1 16480452313.1 818
54.17
 GitHub Action Run
Source Files on build 16480452313