Qiskit / qiskit / 16481061798

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Remove Python dependency from ElidePermutations (#14669)

* Remove Python dependency from ElidePermutations

The ElidePermutations pass previously required the py token when calling
the function. This was needed for two things, one is calling count_ops()
the other is handling permutation gates. The count ops call doesn't
actually need a python token. It was calling the wrong function, since
elide permutation doesn't deal with recursing into control flow it doesn't
recurse into blocks to detect if there are permutation gates. The py
token on the call it was making was to facilitate recursing into control
flow (which is defined in python). Instead this commit just updates the
usage to get the reference to the counts hashmap directly. The second
usage of handling permutation gates is still needed. That's because
permutation gate is an operation defined in Python so to access the
permutation from the gate we need python. If we are calling the pass
from C this means we can't encounter this branch because by definition
we can't have a permutation gate. So this moves the Python token usage to
inside the permutation gate branch with `Python::with_gil()` so the
path without a permutation gate doesn't require python.

This should enable exposing the pass as a standalone function (see: #14442)
but tihs is currently blocked on being able to run dag->circuit
conversion without python. Once that is implemented we can add a C API
for the standalone pass.

* Change condition on rust types instead of strings

* Simplifiy code

Run Details

23 of 24 new or added lines in 1 file covered. (95.83%)

12 existing lines in 2 files now uncovered.

81497 of 92865 relevant lines covered (87.76%)

546215.52 hits per line