payjoin / rust-payjoin / 16427048792

83%

Build Type

push

github

Committed by web-flow

Commit Message

Add PartialEq/Eq to errors for easier comparison (#768)

The biggest change here is the change of `payjoin::ImplementationError`
from a type alias to a newtype. This update required adding some
implementations to `ImplementationError` from other errors we use. To
prevent adding a bunch of dependencies to `payjoin`, I also opted for
manually wrapping errors using `.map_err(ImplementationError::new)` in
many places instead of implementing `From<SomeNewDependecyError> for
ImplementationError`. It's not necessarily the cleanest; it exposes some
places for improvements in error handling. However, I assume #403 will
tighten some of this up.

Closes #645

Run Details

73 of 99 new or added lines in 9 files covered. (73.74%)

2 existing lines in 2 files now uncovered.

7741 of 9032 relevant lines covered (85.71%)

518.67 hits per line