gluesql / gluesql / 16418737458

99%

push

github

Remove `Ord` impl in `core::data::Interval` (#1674)

This pull request makes GlueSQL stop to support Ord<Interval> and support only PartialOrd<Interval> because comparison between Interval::Month and Interval::Microsecond is ambiguous behavior because 1 month can be one among 28 days, 30 days or 31 days.

The Ord implementation for the Interval enum was removed, and the PartialOrd implementation was updated to make intervals of different variants incomparable. A detailed doc comment was added to the Interval enum clarifying variant semantics. Related tests were updated accordingly. In Key, the comparison logic for Interval variants was adjusted to handle incomparability explicitly by mapping None from partial_cmp to a deterministic ordering based on variant.

16 of 17 new or added lines in 2 files covered. (94.12%)

39473 of 40345 relevant lines covered (97.84%)

59728.29 hits per line