unicode-org / icu4x / 16418162773

73%

Build Type

push

github

Committed by web-flow

Commit Message

Fix several incorrect type inferences in sort key code (#6708)

These variables were int32_t in the C++ code, but during the port their
types got incorrectly inferred as u8, which can cause a panic on
overflow when processing a long string. I adjust them to usize, which is
Rust's idiom.

The narrowings to u8 should all be safe since we're operating with a
value that fits into a u8 at those points. (The same thing is happening
in the C++ too of course, but it's done silently by the compiler.)

Run Details

13 of 29 new or added lines in 1 file covered. (44.83%)

5 existing lines in 5 files now uncovered.

59059 of 81337 relevant lines covered (72.61%)

459405.58 hits per line