GEWIS / sudosos-backend / 16414739982

90%

push

github

feat: improved user search (#543)

Refactored the search query logic to improve clarity. Instead of manually
handling multiple conditions for first name, nickname, and last name separately,
we now use `CONCAT` to allow direct searches of full names.

However, this does mean that the e-mail address of a user now also becomes a
part that is searchable. Kept limit to two for separate parts. Additionally, the
parameters are structured more cleanly.

---

The used collation (`utf32_general_ci`) already ensures case-insensitive
matching. However, as noted in my review in
https://github.com/GEWIS/sudosos-backend/pull/57#pullrequestreview-1607553958,
I still believe using `utf32` is unnecessary at best and `utf8mb4` should be
used instead (except that TypeORM does not directly allow usage of the
`unicode_ci` variant over `general_ci`). Usage of an `*_unicode_ci` collation
will provide an even better search due to improved character expansion/mapping.

**Update:** rather than `utf8mb4_unicode_ci` we should use
`utf8mb4_uca1400_ai_ci` (the new default from MariaDB 11.5 on).

1306 of 1592 branches covered (82.04%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

7023 of 8182 relevant lines covered (85.83%)

1072.3 hits per line