agama-project / agama / 16411656420

push

github

fix(web): encode URL params for safer URL generation (#2576)

## Problem

Bug report https://bugzilla.suse.com/show_bug.cgi?id=1246551 (private
link) revealed that some URL parameters were not being properly encoded.
This led to issues where users could not access certain resources when
special characters (e.g., #, $, spaces) were present in the URL path.

## Solution

Introduced a new utility function, `generateEncodedPath`, which wraps
React Router's `generatePath` and ensures all path parameters are safely
URI-encoded using
[encodeURIComponent](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent).

Replaced all occurrences of `generatePath` in the codebase with
`generateEncodedPath`, adapting parameters where needed to ensure
compatibility.

2135 of 3880 branches covered (55.03%)

Branch coverage included in aggregate %.

41 of 54 new or added lines in 11 files covered. (75.93%)

24759 of 37991 relevant lines covered (65.17%)

49.0 hits per line