spesmilo / electrum / 5962873077235712

60%

master: 63%

Build Type

Pull #10059

CirrusCI

Committed by f321x

Commit Message

fix: cli: check_hold_invoice showing settled invoice as unpaid

the cli command `check_hold_invoice` incorrectly assumes that
`lnworker.is_accepted_mpp(payment_hash)` is true for settled invoices,
however it is not as the received mpp entries will be removed from
the `lnworker.received_mpp_htlcs` shortly after adding the preimage to
lnworker (after the htlcs got removed from the channel).

Also renames `amount_sat` in the `check_hold_invoice` response to
`amount_sat_received` to make it more obvious that this is the currently
received amount instead of the amount the invoice of `payment_hash` has
been created with.

Pull Request Pull Request #10059: fix: cli: check_hold_invoice showing settled invoice as unpaid

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

22000 of 36779 relevant lines covered (59.82%)

2.99 hits per line