NatLibFi / ekirjasto-web-patron / 16366331977

81%

Build Type

push

github

Committed by web-flow

Commit Message

PP-2666 : present only the first supported authentication method from auth doc (#68)

## Description

<!--- Describe your changes -->
When navigating to the login screen, a user will no longer be given the
option to select a login method if their auth doc provides more than one
authentication method. Instead, CPW now only grabs the first supported
authentication method provided.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Authentication is driven and configured by the auth document provided
from the circulation manager, namely by ordering the authentication
methods by priority. The first supported authentication method in the
list should be preferred. Expressly using the first auth method provided
keeps CPW in line with how the CM wants to manage authentication.

Also, removing the user's freedom to choose which authentication method
removes unnecessary ambiguity between some auth methods. For example,
distinguishing between Basic or Basic Token auth may not be a meaningful
choice for a user and does not provide an intuitive UX.

<!--- If it fixes an open issue, please link to the issue here. -->

[Jira PP-2666](https://ebce-lyrasis.atlassian.net/browse/PP-2666)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

Run Details

829 of 1083 branches covered (76.55%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

1414 of 1601 relevant lines covered (88.32%)

29.39 hits per line