mozilla-releng / balrog / #4765

90%

main: 89%

push

circleci

feat: add statsd timings for admin endpoints (#3467)

* refactor: rename a number of request handler functions

I plan to use these in metric names, and they could do with a clean-up for consistency, brevity, and understandability.

* feat: add statsd timings for admin endpoints

The most important things we need to time here are the /releases endpoints, as they are (mostly) the only ones used frequently, and we also believe them to be some of the least performant ones. I don't think there's much downside to timing just about everything though, especially considering most of them are rarely used, and won't generate data most of the time.

One way I looked at doing this and ultimately rejected was using a `timer` decorator on specific handlers. This had the upside of allowing custom metric names to be set as an argument (which would've avoided renaming everything), but I decided that decorating everything was both ugly, and not very future proof (we'd probably forget to decorate things in the future).

3054 of 3571 branches covered (85.52%)

Branch coverage included in aggregate %.

163 of 166 new or added lines in 11 files covered. (98.19%)

5680 of 6199 relevant lines covered (91.63%)

0.92 hits per line