kubevirt / containerized-data-importer / #5491
49%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 155
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.326% (-0.2%) from 59.502%
#5491

push

travis-ci

web-flow 
Populate DV with events from PVC Prime (#3764)

* update role for controller so it can get list of events

Signed-off-by: dsanatar <dsanatar@redhat.com>

* add new field index for events so we can filter by the object's name. add new function that gets all events associated with a primePvc and re-emits them for the regular pvc

Signed-off-by: dsanatar <dsanatar@redhat.com>

* add watcher for Events filtered by PVC type. modify copyEvent func to only emit unique events from primePVC

Signed-off-by: dsanatar <dsanatar@redhat.com>

* add new field index for event uids so we can filter accordingly

Signed-off-by: dsanatar <dsanatar@redhat.com>

* sort events by most recent timestamps and so we can loop more efficiently to emit new events

Signed-off-by: dsanatar <dsanatar@redhat.com>

* fix linting

Signed-off-by: dsanatar <dsanatar@redhat.com>

* modify watcher to filter on only prime pvc events. move copyEvents to ReconcileTargetPvc func. modify copyEvents logic to handle edge case where events have same timestamps

Signed-off-by: dsanatar <dsanatar@redhat.com>

* add missing bracket

Signed-off-by: dsanatar <dsanatar@redhat.com>

* modify CopyEvents func to take in two client.Objects instead so we can resuse the same func when we need to copy events from primePvc to pvc and from pvc to dv

Signed-off-by: dsanatar <dsanatar@redhat.com>

* move func call to CopyEvents to emitEvents func so it only occurs when DVs status has changed

Signed-off-by: dsanatar <dsanatar@redhat.com>

* add conditional to CopyEvents so when we are handling DVs we only copy over events from the primePVC

Signed-off-by: dsanatar <dsanatar@redhat.com>

* remove debug logs

Signed-off-by: dsanatar <dsanatar@redhat.com>

* reuse existing function to add pvcPrime name annotation to import populator so that we can access the prime name downstream

Signed-off-by: dsanatar <dsanatar@redhat.com>

* update DV bound condition to include PVC Prime name if one exists while the claim is stil... (continued)

75 of 206 new or added lines in 11 files covered. (36.41%)

5 existing lines in 2 files now uncovered.

17163 of 28930 relevant lines covered (59.33%)

0.66 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
42.56
 0.0% pkg/uploadproxy/uploadproxy.go
2
74.43
 -0.12% pkg/controller/clone-controller.go
2
71.39
 -0.01% pkg/controller/import-controller.go
2
56.86
 -0.17% pkg/controller/populators/clone-populator.go
2
59.09
 -1.35% pkg/controller/populators/upload-populator.go
2
77.27
 -0.05% pkg/controller/upload-controller.go
3
96.95
 -2.24% pkg/controller/datavolume/conditions.go
20
57.32
 -4.18% pkg/controller/populators/import-populator.go
26
60.97
 -1.94% pkg/controller/populators/populator-base.go
71
14.26
 0.22% pkg/controller/common/util.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
57.32
 -4.18% pkg/controller/populators/import-populator.go
4
75.53
 -1.06% pkg/importer/http-datasource.go
Jobs
ID Job ID Ran Files Coverage
1 #5491.1 155
59.33
Source Files on build #5491