Qiskit / qiskit / 16324690703

88%

Build Type

push

github

Committed by web-flow

Commit Message

Directly use PackedOperation for two qubit decomposers (#14650)

* Directly use PackedOperation for two qubit decomposers

This commit reworks the rust code for the two qubit decomposers to
natively work with PackedOperation instead of doing
`Option<StandardGate>` to represent either a StadandardGate::CX gate
for cx based decomposition and `None` for any other gate used for the 2q
target. Prior to having a more complete circuit data model defined in
rust the two qubit decomposers were written using string identifiers
where 1q gates were represented by their names and 2q gates were either CX
or a sentinel value USER_GATE. This was because the
TwoQubitBasisDecomposer has a custom code path that is CX only, but the
other KAK gates used in the decomposer are generic. The USER_GATE string
was used to tell the python code which was constructing the circuit from
a gate sequence to use the gate instance stored in the python class
instead of something hard coded. This enabled standard gates and custom
gates.

However, since the two qubit decomposers were originally ported to Rust
the Rust side of Qiskit has grown significantly and we can now natively
build the circuit fully in Rust and represent all the operations. The
model used in the decomposers was then expanded to work with Rust native
gate representations but the same pattern using the sentinel value and
custom operation reconstruction in Python was still used. This mismatch
has caused confusion like as reported in #14418 but also hinders the
usage of the decomposers in other rust callers. For example, looking at
implementing #12213 we will need to work with the two qubit decomposer
directly in rust for the qsd implementation and working with gates
natively in rust will be necessary.

This commit migrates the custom sequene type used for the two qubit
decomposer to work natively with a PackedOperation and store all
operations used in the sequence. We can consider removing the custom
sequence type once th... (continued)

Run Details

251 of 274 new or added lines in 5 files covered. (91.61%)

11 existing lines in 4 files now uncovered.

81477 of 92833 relevant lines covered (87.77%)

549036.06 hits per line