agama-project / agama / 16317571768

push

github

feat(cli): Added -i/--insecure optional argument to the "agama download" command (#2568)

## Problem

- The `agama download` command fails when downloading from HTTPS with a
self-signed certificate
- It should be possible to ignore the problem and download the file
anyway (only on explicit user request)
- Useful for testing, might be used by customers in local networks
- https://bugzilla.suse.com/show_bug.cgi?id=1245393

## Solution

- Ignore SSL problems in HTTPS downloads (self-signed certificate,
non-matching host, unknown CA...)

## Testing

- Tested manually

### Fails by default 

Downloading from HTTPS server using a self-signed certificate fails:

```console
> ./agama download https://localhost:9000 index.html
Could not retrieve https://localhost:9000/

Caused by:
    [60] SSL peer certificate or SSH remote key was not OK (SSL certificate problem: self-signed certificate)
```

### Using the `--insecure` option

When using the `--insecure` option the problem is ignored and the
download succeeds:

```console
> ./agama download --insecure https://localhost:9000 index.html
File saved to index.html
```

### Help

The option is described in the help output:

```console
> ./agama download --help
Download file from a given (AutoYaST) URL

The purpose of this command is to download files using AutoYaST supported schemas (e.g. device://).
It can be used to download additional scripts, configuration files and so on. You can use it for
downloading Agama autoinstallation profiles. If you want to convert an AutoYaST profile, use "agama
config generate".

Usage: agama download [OPTIONS] <URL> <DESTINATION>

Arguments:
  <URL>
          URL reference pointing to file for download. If a relative URL is provided, it will be
          resolved against the current working directory

  <DESTINATION>
          File name

Options:
  -i, --insecure
          Disables SSL verification for HTTPS downloads

  -h, --help
          Print help (see a summary with '-h')
```

2000 of 3646 branches covered (54.85%)

Branch coverage included in aggregate %.

5 of 12 new or added lines in 6 files covered. (41.67%)

22228 of 28238 relevant lines covered (78.72%)

64.44 hits per line