rust-bitcoin / rust-bitcoin / 16302071048

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4640: Remove `non_exhausive` from `Network`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/bcf0c3d92bd890b8b40f96cb010f2366805d77da">bcf0c3d92<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a8e6ab7b0f332305a9af8ce86dd9fdb81232f403"> bitcoin: Add a test for matching on network (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1e69e63367b57eaa12c07752760d6a7c486bc62b">1e69e6336</a> Remove non_exhausive from Network (Tobin C. Harding)

Pull request description:

  Note that Kix is AWOL at the moment so we will need to let this sit for a good while so he gets a chance to see it since he is central to the debate in #2225.
  
  Issue #2225 is long and has many valid opposing opinions. The main argument for having non_exhaustive is that it helps future proof the ecosystem at the cost of pain now. The main argument against having non_exhaustive is why have pain now when adding a network is so rare that having pain then is ok.
  
  At the end of the thread Andrew posts:
  
  > I continue to think we should have an exhaustive enum, with a bunch of
  > documentation about how to use it properly. I am warming up to the
  > "don't have an enum, just have rules for defining your own" but I think
  > this would be needless work for people who just want to grab an
  > off-the-shelf set of networks or people who want to make their own enum
  > but want to see an example of how to do it first.
  
  In order to make some forward progress lets remove the `non_exhaustive` now and backport this change to 0.32, 0.31, an 0.30.
  
  Later we can add, and release in 0.33, whatever forward protection / libapocalyse protection we want to add.
  
  This removes the pain now and gives us a path to prevent future pain - that should keep all parties happy.


ACKs for top commit:
  apoelstra:
    ACK bcf0c3d92bd890b8b40f96cb010f2366805d77da; successfully ran local tests
  luisschwab:
    ACK bcf0c3d92bd890b8b40f96cb010f2366805d77da


Tree-SHA512: d8c24e8d2dfcbd55977fa9dc4f63a2231b1

21303 of 25497 relevant lines covered (83.55%)

15300.7 hits per line