tari-project / tari / 16294860984

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix: blocking main tokio thread when reading last latency (#7320)

Description
---
Fix minotari_console_wallet panic when attempting to block main tokio
thread with error message:
 ```
Cannot block the current thread from within a runtime. This happens
because a function attempted to block the current thread while the
thread is being used to drive asynchronous tasks
 ```
This happens because function `is_online` which was not async tried to
do blocking read on the `tokio::sync::RwLock` on main tokio thread. This
is not allowed since it would also block every other async action
causing in thread panic.

Motivation and Context
---
Fix sporadic wallet failures when repeatedly called `is_online` mostly
seen when bridging tokens.

How Has This Been Tested?
---
Just ran `cargo check` and verified that changing all functions
definition to `async` causes not error even so other functions in the
same trait were also `async`.

What process can a PR reviewer use to test or verify this change?
---
Basic code review of changes.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Improved wallet connectivity checks to use asynchronous operations for
better performance and responsiveness. No user-facing changes in
functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

0 of 5 new or added lines in 2 files covered. (0.0%)

34 existing lines in 5 files now uncovered.

69801 of 120694 relevant lines covered (57.83%)

225660.84 hits per line