tari-project / tari / 16272458029
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 718
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.167% (-0.9%) from 58.047%
16272458029

push

github

web-flow 
feat: modify soft disconnect criteria (#7307)

Description
---
We can be more efficient with soft disconnects when we compare against
expected RPC sessions and substream counts. This PR adds finer
discernment when doing soft peer disconnects.

Motivation and Context
---
The health check opens 2 substreams and 0 PRC sessions - that should
result in a disconnect if those are the only opened resources.

How Has This Been Tested?
---
System-level testing
```rust
2025-07-11 13:52:26.703289300 [comms::connection_manager::peer_connection] TRACE Hard disconnect - requester: 'Health check', peer: `d7c289e9e3c8377705ce599a96`, RPC clients: 0, substreams 2
2025-07-11 13:52:26.705658100 [comms::connection_manager::peer_connection] TRACE Soft disconnect - requester: 'Health check', peer: `0984896e74022c442c1034852c`, RPC clients: 1, substreams 3, NOT disconnecting
2025-07-11 13:52:26.705735900 [comms::connection_manager::peer_connection] TRACE Hard disconnect - requester: 'Health check', peer: `d025bc9e4bd423a9b304c491b8`, RPC clients: 0, substreams 2
2025-07-11 13:52:26.707647400 [comms::connection_manager::peer_connection] TRACE Hard disconnect - requester: 'Health check', peer: `51af08aff11f7129b4681d9950`, RPC clients: 0, substreams 2
```

What process can a PR reviewer use to test or verify this change?
---
Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
##... (continued)

31 of 46 new or added lines in 6 files covered. (67.39%)

1102 existing lines in 27 files now uncovered.

68701 of 120177 relevant lines covered (57.17%)

226749.69 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
55.87
 0.87% comms/core/src/connectivity/manager.rs
6
76.2
 0.59% comms/core/src/connection_manager/peer_connection.rs
8
0.0
 0.0% base_layer/core/src/base_node/tari_pulse_service/mod.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% base_layer/core/src/base_node/tari_pulse_service/mod.rs
1
87.35
 -0.41% base_layer/core/src/blocks/block_header.rs
1
60.91
 0.94% comms/dht/src/connectivity/mod.rs
3
25.0
 -12.5% base_layer/common_types/src/epoch.rs
3
47.73
 -6.82% base_layer/core/src/blocks/historical_block.rs
3
38.57
 -4.29% base_layer/core/src/validation/mocks.rs
3
19.35
 -4.84% infrastructure/test_utils/src/streams/mod.rs
4
88.89
 -4.44% base_layer/core/src/test_helpers/block_spec.rs
5
0.0
 -27.78% base_layer/core/src/base_node/proto/rpc.rs
5
85.71
 -4.46% base_layer/core/src/common/rolling_vec.rs
5
75.36
 -7.25% base_layer/core/src/consensus/chain_strength_comparer.rs
6
73.24
 -8.45% base_layer/common_types/src/types/fixed_hash.rs
8
0.0
 -12.31% base_layer/core/src/validation/error.rs
9
91.65
 -1.12% base_layer/core/src/consensus/consensus_constants.rs
11
50.0
 -50.0% base_layer/core/src/chain_storage/smt_hasher.rs
12
46.04
 -4.32% base_layer/core/src/chain_storage/db_transaction.rs
13
85.76
 -1.41% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
17
37.08
 -9.55% base_layer/core/src/transactions/transaction_components/output_features.rs
20
69.09
 -18.18% base_layer/core/src/transactions/transaction_components/side_chain/validator_node_registration.rs
21
0.0
 -27.63% base_layer/core/src/transactions/transaction_components/side_chain/sidechain_feature.rs
22
75.0
 -25.0% base_layer/core/src/base_node/sync/rpc/tests.rs
23
8.33
 -31.94% base_layer/core/src/chain_storage/block_add_result.rs
23
61.41
 -6.25% base_layer/core/src/chain_storage/lmdb_db/lmdb.rs
26
62.56
 -3.86% base_layer/core/src/test_helpers/blockchain.rs
64
12.29
 -15.42% base_layer/core/src/base_node/sync/rpc/service.rs
368
44.51
 -12.61% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
425
41.78
 -14.59% base_layer/core/src/chain_storage/blockchain_database.rs
Jobs
ID Job ID Ran Files Coverage
1 16272458029.1 718
57.17
 GitHub Action Run
Source Files on build 16272458029