MITLibraries / timdex-dataset-api / 16269288984

96%

main: 93%

Pull #154

github

Use DuckDB secret vs PRAGMA for MinIO

Why these changes are being introduced:

While PRAGMA configurations worked for direct parquet file
reading in a local MinIO S3 instance, it did not work for
DuckDB ATTACH statements.

How this addresses that need:

By using a DuckDB secret, setting the MinIO S3 endpoint
and credentials there, other statments like ATTACH work
as expected.

This is overall a better approach anyways!  The PRAGMA
approach seemed like the only option originally, but this
edge case of ATTACH forced revisiting it and this use of
secrets does in fact work.

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-515

12 of 14 new or added lines in 2 files covered. (85.71%)

315 of 328 relevant lines covered (96.04%)

0.96 hits per line