• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

cryptoquick / rust-bitcoin / 16250349584
84%
lnhance: 83%

Build:
Build:
LAST BUILD BRANCH: p2mr
DEFAULT BRANCH: lnhance
Ran 13 Jul 2025 02:51PM UTC
Jobs 1
Files 129
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Jul 2025 01:19PM UTC coverage: 83.547% (+0.5%) from 83.083%
16250349584

push

github

apoelstra
Merge rust-bitcoin/rust-bitcoin#4649: fix: preserve embedded nulls in `CommandString` for consensus validation

<a class=hub.com/cryptoquick/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/cryptoquick/rust-bitcoin/commit/a6f63cf61d921e6c59f0697f9b84afd744ddbf37">a6f63cf61 fix: validate ASCII and preserve embedded nulls in CommandString parsing (Erick Cestari)

Pull request description:

  Previously, `CommandString` decoding would silently normalize invalid commands containing embedded null bytes. For example, "mem\0pool" would be incorrectly decoded as "mempool", bypassing consensus validation.
  
  Found through differential fuzzing between btcd and rust-bitcoin, where rust-bitcoin was accepting messages with embedded null bytes in Command fields while btcd (and Bitcoin Core) correctly reject them.


ACKs for top commit:
  apoelstra:
    ACK a6f63cf61d921e6c59f0697f9b84afd744ddbf37; successfully ran local tests
  tcharding:
    ACK a6f63cf61d921e6c59f0697f9b84afd744ddbf37


Tree-SHA512: fccf7fc29448d5e05f5b7a4bc8bc8675a1d

12 of 12 new or added lines in 1 file covered. (100.0%)

1825 existing lines in 75 files now uncovered.

21297 of 25491 relevant lines covered (83.55%)

15326.34 hits per line

Coverage Regressions

Lines Coverage ∆ File
211
67.26
1.03% bitcoin/src/crypto/key.rs
174
77.05
-0.84% bitcoin/src/taproot/mod.rs
158
86.65
5.8% bitcoin/src/psbt/mod.rs
105
85.34
0.69% bitcoin/src/bip32.rs
60
38.74
-1.86% bitcoin/src/blockdata/script/push_bytes.rs
55
64.71
8.67% units/src/locktime/absolute.rs
54
93.28
-0.65% bitcoin/src/blockdata/transaction.rs
47
6.41
1.09% io/src/bridge.rs
44
91.64
-0.42% bitcoin/src/address/mod.rs
41
79.15
0.54% bitcoin/src/blockdata/script/borrowed.rs
37
84.62
-1.37% bitcoin/src/blockdata/block.rs
37
23.73
-18.79% units/src/amount/error.rs
34
74.31
-0.45% bitcoin/src/blockdata/script/owned.rs
34
81.87
-4.12% units/src/fee_rate/mod.rs
33
21.88
0.88% units/src/fee_rate/serde.rs
32
79.14
-4.84% bitcoin/src/network/mod.rs
32
83.08
5.88% units/src/block.rs
31
89.07
14.86% primitives/src/locktime/relative.rs
29
82.63
6.1% units/src/locktime/relative.rs
26
25.49
-0.83% bitcoin/src/crypto/taproot.rs
26
79.1
-1.32% io/src/lib.rs
26
81.12
1.12% units/src/amount/signed.rs
25
38.24
0.89% hashes/src/internal_macros.rs
25
87.05
-1.52% primitives/src/locktime/absolute.rs
25
89.45
-0.23% units/src/weight.rs
24
89.97
1.04% units/src/amount/mod.rs
22
79.67
-0.47% bitcoin/src/bip152.rs
22
14.29
-0.47% bitcoin/src/psbt/error.rs
21
95.4
-0.34% bitcoin/src/consensus/encode.rs
21
74.07
-25.93% internals/src/slice.rs
19
81.15
-0.81% hashes/src/macros.rs
17
92.61
-0.59% bitcoin/src/bip158.rs
17
46.43
6.0% hashes/src/sha256t/mod.rs
16
91.8
13.2% primitives/src/transaction.rs
15
81.01
2.44% bitcoin/src/blockdata/script/builder.rs
15
92.96
17.44% primitives/src/script/mod.rs
15
96.58
1.72% primitives/src/witness.rs
14
92.31
1.0% hashes/src/hmac/mod.rs
12
93.78
-0.41% bitcoin/src/psbt/map/input.rs
12
88.37
5.04% units/src/amount/unsigned.rs
11
86.32
2.98% bitcoin/src/blockdata/script/mod.rs
11
37.17
-10.95% internals/src/serde.rs
10
86.92
0.93% bitcoin/src/blockdata/script/witness_program.rs
10
96.27
-0.03% bitcoin/src/psbt/serialize.rs
9
90.91
-3.91% bitcoin/src/blockdata/witness.rs
9
86.15
2.59% bitcoin/src/psbt/raw.rs
9
72.94
15.16% hashes/src/sha256/mod.rs
9
98.79
0.36% units/src/amount/tests.rs
8
91.33
-2.9% units/src/amount/serde.rs
7
93.97
-0.86% bitcoin/src/blockdata/constants.rs
7
97.54
-1.0% chacha20_poly1305/src/chacha20.rs
6
55.81
-0.57% chacha20_poly1305/src/lib.rs
6
96.7
-0.2% hashes/src/siphash24/mod.rs
5
47.06
0.0% bitcoin/src/network/params.rs
5
85.25
1.49% primitives/src/sequence.rs
5
89.8
15.51% units/src/amount/result.rs
5
77.27
39.77% units/src/time.rs
3
60.98
-1.82% bitcoin/src/internal_macros.rs
3
94.55
-0.19% hashes/src/sha256d/mod.rs
3
98.64
9.12% primitives/src/block.rs
3
91.53
-0.97% primitives/src/script/borrowed.rs
2
89.47
-5.26% bitcoin/src/lib.rs
2
70.77
-2.42% bitcoin/src/psbt/map/global.rs
2
96.55
0.84% bitcoin/src/psbt/map/output.rs
2
89.47
-10.53% units/src/internal_macros.rs
1
98.62
0.46% base58/src/lib.rs
1
46.49
0.73% bitcoin/src/consensus/serde.rs
1
85.3
0.93% bitcoin/src/crypto/sighash.rs
1
98.08
-0.04% hashes/src/hash160/mod.rs
1
96.77
-0.2% hashes/src/ripemd160/mod.rs
1
96.77
-0.2% hashes/src/sha1/mod.rs
1
98.85
0.0% hashes/src/sha384/mod.rs
1
98.7
0.0% hashes/src/sha512_256/mod.rs
1
98.18
-0.06% hashes/src/sha512/mod.rs
1
74.15
0.46% units/src/parse.rs
Jobs
ID Job ID Ran Files Coverage
1 16250349584.1 13 Jul 2025 02:51PM UTC 129
83.55
GitHub Action Run
Source Files on build 16250349584
  • Tree
  • List 129
  • Changed 109
  • Source Changed 94
  • Coverage Changed 106
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #16250349584
  • 5f4d71e9 on github
  • Prev Build on master (#13941248875)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc