|
Ran
|
Jobs
1
|
Files
129
|
Run time
1min
|
Badge
README BADGES
|
push
github
Merge rust-bitcoin/rust-bitcoin#4649: fix: preserve embedded nulls in `CommandString` for consensus validation <a class=hub.com/cryptoquick/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/cryptoquick/rust-bitcoin/commit/a6f63cf61d921e6c59f0697f9b84afd744ddbf37">a6f63cf61 fix: validate ASCII and preserve embedded nulls in CommandString parsing (Erick Cestari) Pull request description: Previously, `CommandString` decoding would silently normalize invalid commands containing embedded null bytes. For example, "mem\0pool" would be incorrectly decoded as "mempool", bypassing consensus validation. Found through differential fuzzing between btcd and rust-bitcoin, where rust-bitcoin was accepting messages with embedded null bytes in Command fields while btcd (and Bitcoin Core) correctly reject them. ACKs for top commit: apoelstra: ACK a6f63cf61d921e6c59f0697f9b84afd744ddbf37; successfully ran local tests tcharding: ACK a6f63cf61d921e6c59f0697f9b84afd744ddbf37 Tree-SHA512: fccf7fc29448d5e05f5b7a4bc8bc8675a1d
12 of 12 new or added lines in 1 file covered. (100.0%)
1825 existing lines in 75 files now uncovered.21297 of 25491 relevant lines covered (83.55%)
15326.34 hits per line
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 16250349584.1 | 129 |
83.55 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|