dcdpr / jp / 16230190925

58%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(config): Simplify configuration file loading architecture (#181)

A vacation special, coming in hot after a couple of evenings relaxing
and typing away on a beach in Normandy, France.

---

Previously, configuration loading used a complex recursive search system
that was difficult to understand and maintain. The new approach loads
configuration files from specific, well-defined locations in a clear
order, making the system more predictable and easier to reason about.

The loading order is now explicitly defined as:

1. `$XDG_CONFIG_HOME/jp/config.toml` (user-global)
2. `<workspace>/.jp/config.toml` (workspace)
3. `$CWD/.jp.toml` (current directory, recursively upwards)
4. `$XDG_DATA_HOME/jp/<workspace_id>/config.toml` (user-workspace)

Key architectural changes include separating the monolithic
`load_partial_from_file` function into focused, single-purpose
functions: `load_partials_with_inheritance` for inheritance logic,
`load_partial_at_path` for loading single files, and
`load_partial_at_path_recursive` for directory traversal. The
inheritance logic is now explicit and centralized, making it easier to
understand when and why configuration inheritance is disabled.

This refactoring improves code maintainability and adds extensive test
coverage for the new loading logic.

This commit also adds an initial effort to document the configuration
loading mechanism at https://jp.computer/configuration.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Run Details

100 of 205 new or added lines in 13 files covered. (48.78%)

16 existing lines in 6 files now uncovered.

3922 of 11026 relevant lines covered (35.57%)

4.14 hits per line