tari-project / tari / 16218940838
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 718
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 58.046% (-0.02%) from 58.066%
16218940838

push

github

web-flow 
fix: seed peers being disconnected while seedstrap is in progress (#7303)

Description
---
- Fixed seedstrap seeds disconnecting during the seedstrap phase. This
was caused by the health service, which obtained connections to all seed
peers and disconnected them while seedstrap was busy. This was fixed by
adding a soft disconnect alongside the hard disconnect in
`peer_connection.rs::PeerConnection`, so that a parallel spawned process
can politely request connections to be broken if they are not in use.
- Also added better logging information for peer disconnects, in that
the requester is also logged.

Motivation and Context
---
Seed peer connections are being dropped while still busy streaming peer
info via RPC during seedstrap.

How Has This Been Tested?
---
System-level testing

Seedstrap can now finish within 3s if there are no seed peer connection
issues:
```rust
[comms::dht::network_discovery::seed_strap] INFO  SeedStrap: Original early exit conditions met. Total peers added (455) >= needed (15). Successful seed contacts (5) >= min (5). Exiting seed node loop.
[comms::dht::network_discovery::seed_strap] INFO  SeedStrap: discover_peers_via_seeds finished. Attempted to contact: 5/5. Successfully synced from: 5. Total new peers added in this round: 455. Total duplicates processed in this round: 38.
[comms::dht::network_discovery::seed_strap] INFO  SeedStrap: Peer DB counts after seed bootstrap completion: Total peers in DB = 468, Non-seed peers in DB = 455
[comms::dht::network_discovery::seed_strap] INFO  SeedStrap: Added 455 (new) peers via seed nodes (5 successful seed node contacts).
[comms::dht::network_discovery::seed_strap] DEBUG SeedStrap: Round info at completion - new_peers: 455, duplicate_peers: 38, succeeded: 5, sync_peers_contacted: 5
[comms::dht::network_discovery] DEBUG Transition triggered from current state `SeedStrap` by event `DiscoveryComplete(Synced 5/5, num_new_peers = 455, num_duplicate_peers = 38)`
[comms::dht::network_discove... (continued)

69 of 153 new or added lines in 9 files covered. (45.1%)

13 existing lines in 4 files now uncovered.

69753 of 120169 relevant lines covered (58.05%)

226917.3 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
75.0
 -0.31% base_layer/p2p/src/services/liveness/service.rs
4
0.0
 0.0% base_layer/p2p/src/services/monitor_peers/service.rs
4
0.0
 0.0% comms/dht/src/network_discovery/seed_strap.rs
7
0.0
 0.0% base_layer/core/src/base_node/tari_pulse_service/mod.rs
29
75.62
 -3.88% comms/core/src/connection_manager/peer_connection.rs
37
55.33
 -1.6% comms/core/src/connectivity/manager.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% base_layer/core/src/base_node/tari_pulse_service/mod.rs
1
93.35
 -0.18% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
3
59.97
 -0.4% comms/dht/src/connectivity/mod.rs
8
55.33
 -1.6% comms/core/src/connectivity/manager.rs
Jobs
ID Job ID Ran Files Coverage
1 16218940838.1 718
58.05
 GitHub Action Run
Source Files on build 16218940838