blues / note-c / 16219610694

93%

push

github

TS-713: Fix CRC errors over AUX serial in card.binary HIL tests. (#198)

In this PR, we removed code that automatically called card.aux.serial with ms
and max parameters to add flow control for AUX serial comms in note-arduino:
https://github.com/blues/note-arduino/pull/141 It turns out these tests were
relying on that behavior in order to not have Notecard responses over AUX
serial wind up corrupted. This corruption was manifesting as CRC errors on the
responses. I saw with a logic analyzer that the Notecard was sending the correct
response, but that note-c/the Swan was not receiving it correctly. So the fix
is to restore the card.aux.serial request with the old ms and max parameters by
adding it to the test.

1156 of 1331 branches covered (86.85%)

Branch coverage included in aggregate %.

2381 of 2470 relevant lines covered (96.4%)

80.37 hits per line